Add new SpeedMod options to Edit and Practice modes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Šimo <[email protected]>
kubik369
force-pushed
the
add-speed-mod-practice
branch
from
487c07c to
bc4b20a
Compare
|
I have updated the code to only apply when in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the Edit/Practice game mode had some older speed mod setting rows where you could only choose between a few X-mod options and C150/C300. This PR adds the new options, which are default in the theme in standard play (at least on dance).
I have almost no idea whether this does not break something else. I have tried looking around, it does not break the additional options screens, I could play a few songs just fine, swapping between the edit/practice modes, changing the speed options from one to the other and vice versa.
Thanks for checking it out :)