Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter-condition): display all variables for date component not only date type once [TCTC-7312] #1953

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

alice-sevin
Copy link
Contributor

@alice-sevin alice-sevin commented Nov 21, 2023

Display all variables, not only date once for date column in filter editor.

Before:
before

After:
after

Test :
https://weaverbird-playground-pr-1953.onrender.com/

@alice-sevin alice-sevin self-assigned this Nov 21, 2023
Copy link

render bot commented Nov 21, 2023

@alice-sevin alice-sevin changed the title fix(filter-condition): display all variables for date component not only date type once fix(filter-condition): display all variables for date component not only date type once [TCTC-7312] Nov 21, 2023
@alice-sevin alice-sevin added bug Something isn't working need review labels Nov 21, 2023
Copy link
Member

@davinov davinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est un peu dommage de perdre cette feature, qui évitait sûrement des erreurs de types, mais bon si c'est specé comme ca par le produit 🤷
En tout cas c'est très clair 💯

@alice-sevin alice-sevin merged commit 0349690 into master Nov 21, 2023
2 checks passed
@alice-sevin alice-sevin deleted the fix/date-input-display-all-variables branch November 21, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants