Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change history invoice #525

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

tomasandrejdes
Copy link

Description

<I created a new model for storing invoice change history in JSON.
It is also possible to restore the invoice from the history or view only its preview, where there will be a warning that it is not a valid invoice, I did not create a new template but I added a condition for displaying the information to the original one->

Checklist

  • [ X] Ran the Black Formatter and
    djLint-er on any new code
    (checks
    will
    fail without)
  • Made any changes or additions to the documentation where required
  • [X ] Changes generate no new warnings/errors
  • New and existing unit tests pass locally with my
    changes

What type of PR is this?

  • ✨ Feature

Added/updated tests?

  • 🙋 no, because I need help

Related PRs, Issues etc

  • Related Issue #
  • Closes #

Copy link
Owner

@TreyWW TreyWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Appreciate the job and nice touch with the transaction. I left a few mini comments, let me know if you agree?

Thanks again

backend/finance/models.py Outdated Show resolved Hide resolved
backend/finance/models.py Outdated Show resolved Hide resolved
backend/finance/models.py Outdated Show resolved Hide resolved
@TreyWW
Copy link
Owner

TreyWW commented Nov 14, 2024

Hi Tom, thanks for your patience. Well done with the changes, however there's one issue still with the files where if you add a logo, revert version, and then try and revert again to the one with the logo, the image wont load.

I'm not currently sure why it's using the wrong logo name, but somewhere it's getting mixed up - but both logos are in storage still so that's good.

I'll try and play around and debug this more when I get home later though :)

@github-actions github-actions bot added the Stale label Dec 12, 2024
@github-actions github-actions bot closed this Dec 20, 2024
@TreyWW TreyWW added no-stale and removed Stale labels Dec 25, 2024
@TreyWW TreyWW reopened this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants