TOOLS-2577 Update eng.git for 23.4.0 #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been using these changes while working on updating mahi to build on 23.4.0. |
danmcd
reviewed
Feb 19, 2024
bahamat
requested changes
Mar 5, 2024
| @@ -81,7 +82,7 @@ function mkdir(d) { | |||
|
|
|||
| function gitify(dir, repo) { | |||
| exec('git init', dir, function () { | |||
| exec('git remote add origin git@github.com:joyent/' + repo + '.git', | |||
| exec('git remote add origin https://github.com/TritonDataCenter/' + repo + '.git', | |||
There was a problem hiding this comment.
I think we should probably leave this as ssh here (and probably elsewhere in this PR?). I don't have my gh token set up for doing operations over HTTP, but my ssh key is always available.
| @@ -38,7 +39,7 @@ else | |||
| $(NODE_EXEC) $(NPM_EXEC) $(NODE_WAF_EXEC): | |||
| (mkdir -p $(BUILD) \ | |||
| && cd $(BUILD) \ | |||
| && [[ -d src-node ]] && (cd src-node && git checkout master && git pull) || git clone https://github.com/joyent/node.git src-node \ | |||
| && [[ -d src-node ]] && (cd src-node && git checkout master && git pull) || git clone https://github.com/nodejs/node.git src-node \ | |||
There was a problem hiding this comment.
I'm pretty sure that the branch here will need to be main. I had to fix that in the sdcnode repo. This also makes me wonder if this bit of code even ever gets used anymore...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.