Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass the PyTorchYolo and PyTorchDetectionTransformer estimators off the PyTorchObjectDetector estimator class #2267

Closed
f4str opened this issue Aug 31, 2023 · 1 comment · Fixed by #2321
Assignees
Labels
improvement Improve implementation
Milestone

Comments

@f4str
Copy link
Collaborator

f4str commented Aug 31, 2023

Is your feature request related to a problem? Please describe.
There is a lot of code overlap between the PyTorchYolo, PyTorchDetectionTransformer, and PyTorchObjectDetector estimators. This causes bugs to have to be fixed in both locations when reported. Missed changes in one estimator will still remain a bug in the other. In additional, the big overlap in code is redundant and makes it tedious from a maintenance perspective.

Describe the solution you'd like
The PyTorchYolo estimator should be subclassed off PyTorchObjectDetector. This will reuse a lot of the code and avoid redundant bugs.

Describe alternatives you've considered
N/A

Additional context
This is purely an codebase housekeeping change. Functionality should not be changed in any way.

@beat-buesser beat-buesser changed the title Subclass the PyTorchYolo estimator off the PyTorchObjectDetector estimator Subclass the PyTorchYolo and PyTorchDetectionTransformer estimators off the PyTorchObjectDetector estimator class Sep 1, 2023
@beat-buesser beat-buesser added the improvement Improve implementation label Sep 1, 2023
@beat-buesser beat-buesser added this to the ART 1.17.0 milestone Sep 1, 2023
@beat-buesser
Copy link
Collaborator

Hi @f4str Thank you for opening this feature proposal. I think this is great idea. I have combined the two issues to see both changes in the same PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
Status: Issues closed
2 participants