You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
There is a lot of code overlap between the PyTorchYolo, PyTorchDetectionTransformer, and PyTorchObjectDetector estimators. This causes bugs to have to be fixed in both locations when reported. Missed changes in one estimator will still remain a bug in the other. In additional, the big overlap in code is redundant and makes it tedious from a maintenance perspective.
Describe the solution you'd like
The PyTorchYolo estimator should be subclassed off PyTorchObjectDetector. This will reuse a lot of the code and avoid redundant bugs.
Describe alternatives you've considered
N/A
Additional context
This is purely an codebase housekeeping change. Functionality should not be changed in any way.
The text was updated successfully, but these errors were encountered:
beat-buesser
changed the title
Subclass the PyTorchYolo estimator off the PyTorchObjectDetector estimator
Subclass the PyTorchYolo and PyTorchDetectionTransformer estimators off the PyTorchObjectDetector estimator class
Sep 1, 2023
Is your feature request related to a problem? Please describe.
There is a lot of code overlap between the
PyTorchYolo
,PyTorchDetectionTransformer
, andPyTorchObjectDetector
estimators. This causes bugs to have to be fixed in both locations when reported. Missed changes in one estimator will still remain a bug in the other. In additional, the big overlap in code is redundant and makes it tedious from a maintenance perspective.Describe the solution you'd like
The
PyTorchYolo
estimator should be subclassed offPyTorchObjectDetector
. This will reuse a lot of the code and avoid redundant bugs.Describe alternatives you've considered
N/A
Additional context
This is purely an codebase housekeeping change. Functionality should not be changed in any way.
The text was updated successfully, but these errors were encountered: