Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply package.version.parse #2500

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

beat-buesser
Copy link
Collaborator

@beat-buesser beat-buesser commented Sep 30, 2024

Description

This pull request add application of Python standard library functions to check for version of imported libraries.

Fixes #2437

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Signed-off-by: Beat Buesser <[email protected]>
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (1207d0a) to head (934872a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           dev_1.18.2    #2500   +/-   ##
===========================================
  Coverage       85.24%   85.24%           
===========================================
  Files             329      329           
  Lines           30143    30146    +3     
  Branches         5173     5173           
===========================================
+ Hits            25696    25699    +3     
  Misses           3019     3019           
  Partials         1428     1428           
Files with missing lines Coverage Δ
...ion/adversarial_patch/adversarial_patch_pytorch.py 76.35% <100.00%> (+0.07%) ⬆️
art/attacks/evasion/pixel_threshold.py 90.43% <100.00%> (+0.04%) ⬆️
...mators/object_detection/pytorch_object_detector.py 90.05% <100.00%> (+0.05%) ⬆️

@beat-buesser beat-buesser changed the title Update to ART 1.18.1 Update to ART 1.18.2 Sep 30, 2024
@beat-buesser beat-buesser changed the title Update to ART 1.18.2 Apply package.version.parse Sep 30, 2024
@beat-buesser beat-buesser self-assigned this Sep 30, 2024
@beat-buesser beat-buesser added the improvement Improve implementation label Sep 30, 2024
@beat-buesser beat-buesser added this to the ART 1.18.2 milestone Sep 30, 2024
Copy link
Collaborator

@lockwoodar lockwoodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beat-buesser has explained the nature of the untested lines and I am in agreement why these were originally untested and should remain this way with these updates.

Approved

@beat-buesser
Copy link
Collaborator Author

@lockwoodar Thank you for the review and the detailed description of the solution in issue #2473!

@beat-buesser beat-buesser merged commit 8738a5a into dev_1.18.2 Oct 1, 2024
61 checks passed
@beat-buesser beat-buesser deleted the development_issue_2473 branch October 1, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
None yet
2 participants