Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code scanning alerts #406

Merged
merged 55 commits into from
Dec 5, 2023
Merged

Code scanning alerts #406

merged 55 commits into from
Dec 5, 2023

Conversation

djgroen
Copy link
Contributor

@djgroen djgroen commented Nov 20, 2023

More work needs to be done on this, but I'm creating a pull request to see how the integration tests respond.

DavidPCoster and others added 16 commits November 10, 2023 14:13
@DavidPCoster
reprted by code scanning
d00e4a8
@djgroen
Removed unused variables (comment below describes them already).
32d0682
@DavidPCoster
reprted by code scanning: print a message rather than completely ignore
d23c9d8
@DavidPCoster
Merge branch 'code_scanning_alerts' of github.com:UCL-CCS/EasyVVUQ in…
2365f3b 
…to code_scanning_alerts
@DavidPCoster
reported by code scanning
dd2a983
@DavidPCoster
reported by code scanning
d636994
@DavidPCoster
reported by code scanning
0a73190
@DavidPCoster
reported by code scanning
b8793d7
@djgroen
Fixed test_sobol and made it a proper pytest.
6cb5238
@djgroen
Sharpened the assert criterion in test_sobol.
2f9f39d
@djgroen
Merge branch 'code_scanning_alerts' of github.com:UCL-CCS/EasyVVUQ in…
f627cbb 
…to code_scanning_alerts
@DavidPCoster
reported by code scanning
5dd2841
@DavidPCoster
Merge branch 'code_scanning_alerts' of github.com:UCL-CCS/EasyVVUQ in…
63be3ea 
…to code_scanning_alerts
@djgroen
Removed several more code scanning issues.
1947eda
@djgroen
Merge branch 'code_scanning_alerts' of github.com:UCL-CCS/EasyVVUQ in…
0adb5cc 
…to code_scanning_alerts
@djgroen
Code scanning.
ebea00c
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2023
View reviewed changes
tests/sc/test_sobol.py Fixed Show fixed Hide fixed
djgroen and others added 21 commits December 4, 2023 12:44
@djgroen
Addressing code scanning alert #146.
f152d70
@djgroen
Merge branch 'code_scanning_alerts' of github.com:UCL-CCS/EasyVVUQ in…
b7e310a 
…to code_scanning_alerts
@djgroen
Code scanning issue #147.
80067d7
@djgroen
Fixed several unused variable issues.
134dd30
@JonMcCullough
Update sql.py to remove legacy implementation warnings
256d835
@JonMcCullough
Merge branch 'code_scanning_alerts' of https://github.com/UCL-CCS/Eas…
c09cc37 
…yVVUQ into code_scanning_alerts
@JonMcCullough
Clean sql.py file
6d33000
@JonMcCullough
Edit qmc.py to correct legacy deprecation warning
aa13ffc
@DavidPCoster
only print diagnostic information when EasyVVUQ_Debug set
99aa7c2
@DavidPCoster
only print diagnostic information when EasyVVUQ_Debug set
1614a29
@DavidPCoster
replace .append by .concat
c477522
@DavidPCoster
only print diagnostic information when EasyVVUQ_Debug set
bb5c017
@DavidPCoster
got this one working again
0dba9c5
@DavidPCoster
tomli seems to be required
7f8ea9b
@JonMcCullough
Modify test value of N to remove warning on number of samples not bei…
9f70130 
…ng 2^n
@JonMcCullough
Merge branch 'code_scanning_alerts' of https://github.com/UCL-CCS/Eas…
39911e1 
…yVVUQ into code_scanning_alerts
@DavidPCoster
drop a nuisance field from the params
232d1e9
@DavidPCoster
Merge branch 'code_scanning_alerts' of github.com:UCL-CCS/EasyVVUQ in…
2cc076c 
…to code_scanning_alerts
@DavidPCoster
add fipy as a requirement for one of the tests
f690e2c
@DavidPCoster
test case now works
f4c2a88
@djgroen
Simple typo fix.
5511dc0
DavidPCoster
DavidPCoster approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@DavidPCoster DavidPCoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are trying to fix problems reported by the code scanner, we need the old reports refreshed by these fixes. So I think we should go ahead and attempt to merge these with the develop branch ...

@DavidPCoster
place the 'Sensitivity Analysis: Derivative based' code in a try/exce…
dcecc7a 
…pt structure so that assertion failures don't prevent returning the rest of the statistical data
@DavidPCoster
get the path to the campaign.db from an environment variable DIR; upd…
12c1737 
…ate uq.campaign to uq.Campaign; add the 'sqlite:///' prefix to the db_location
wedeling
wedeling approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@wedeling wedeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@djgroen djgroen merged commit 7c82457 into dev Dec 5, 2023
7 checks passed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2023
View reviewed changes
tutorials/easyvvuq_fusion_analysis.py
@@ -38,7 +39,13 @@

# Read an old campaign
time_start = time.time()
old_campaign = uq.Campaign(state_file="campaign_state.json", work_dir=".")
<<<<<<< HEAD

Check failure

Code scanning / CodeQL

Syntax error Error

Syntax Error (in Python 3).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidPCoster DavidPCoster DavidPCoster approved these changes

@wedeling wedeling wedeling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djgroen @wedeling @DavidPCoster @JonMcCullough