SPL-464 - Update cookie banner #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louis-Solirius
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Great job, don't merge yet though, would like @lambley to have a look first
lambley
requested changes
Nov 1, 2024
lambley
approved these changes
Nov 5, 2024
devind-ra
added a commit
that referenced
this pull request
Nov 6, 2024
* updating cookie banner * fixing issue with accessibility * removing test code in progress * removing extra cookie banner work and changing structure of header * removing extra cookie text * change SERVICE_NAME to title case * remove cookie banner padding * checking cookie banner link and text displayed * fixing lint errors * fixing accept and reject cookies, adding tests to check cookies correctly --------- Co-authored-by: Aaron Lambley <[email protected]>
devind-ra
added a commit
that referenced
this pull request
Nov 13, 2024
* adding new analytical cookies * SPL-479 - Planner: Update "Notify employers" (#282) * fixing notify employer issue * fixing feature test for notifying employers * adding fixes to shared primary parent * adding check for length of secondary spl * SPL-464 - Update cookie banner (#281) * updating cookie banner * fixing issue with accessibility * removing test code in progress * removing extra cookie banner work and changing structure of header * removing extra cookie text * change SERVICE_NAME to title case * remove cookie banner padding * checking cookie banner link and text displayed * fixing lint errors * fixing accept and reject cookies, adding tests to check cookies correctly --------- Co-authored-by: Aaron Lambley <[email protected]> * adding new analytical cookies * adding feature tests for cookie page * fixing lint errors * removing old google analytics cookie from table --------- Co-authored-by: Aaron Lambley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.