Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPL-511 - Refactor page layout and move noscript to header component #297

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

lambley
Copy link
Collaborator

@lambley lambley commented Dec 12, 2024

No description provided.

Copy link
Collaborator

@devind-ra devind-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment only. Otherwise, lgtm.

@@ -0,0 +1,8 @@
{% from "phase-banner/macro.njk" import govukPhaseBanner %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally testing, the phase banner isn't being correctly placed on the screen like this:

Screenshot 2024-12-12 at 15 09 59

Copy link
Collaborator

@devind-ra devind-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lambley lambley merged commit 1b6a40c into master Dec 16, 2024
5 checks passed
@lambley lambley deleted the SPL-511 branch December 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants