-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACL-4279] Update acronym definitions #20
Merged
jeff-horton-ho-sas
merged 8 commits into
main
from
feature/acl-4279--update-acronym-definitions
Nov 21, 2023
Merged
[ACL-4279] Update acronym definitions #20
jeff-horton-ho-sas
merged 8 commits into
main
from
feature/acl-4279--update-acronym-definitions
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeff-horton-ho-sas
commented
Nov 15, 2023
- Add PIL-E
- Provide plural version of definitions
- Sentence case all definitions
- Add PIL-E - Provide plural version of definitions
github-actions
bot
force-pushed
the
feature/acl-4279--update-acronym-definitions
branch
from
November 15, 2023 16:26
aef1770
to
e56e2f3
Compare
…-definitions' into feature/acl-4279--update-acronym-definitions
…-definitions' into feature/acl-4279--update-acronym-definitions
github-actions
bot
force-pushed
the
feature/acl-4279--update-acronym-definitions
branch
from
November 21, 2023 09:37
96a0fd4
to
fcbfe8f
Compare
…-definitions' into feature/acl-4279--update-acronym-definitions
taomoh
reviewed
Nov 21, 2023
package-lock.json
Outdated
"name": "@asl/dictionary", | ||
"version": "1.1.5", | ||
"name": "@ukhomeoffice/asl-dictionary", | ||
"version": "2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this version is not matching the one in package.json (2.1.0) ?
github-actions
bot
force-pushed
the
feature/acl-4279--update-acronym-definitions
branch
from
November 21, 2023 11:08
327b4ab
to
8e82765
Compare
taomoh
approved these changes
Nov 21, 2023
jeff-horton-ho-sas
deleted the
feature/acl-4279--update-acronym-definitions
branch
November 21, 2023 11:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.