Fix PC conventions and add a changelog #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t
.I checked the supported vendor conventions in
pyebsdindex.ebsd_index.EBSDIndexer.index_pats()
, and they now work with the conventions used in kikuchipy, with one exception: The EMsoft convention here corresponds to the EMsoft v4 convention in kikuchipy... I believe it is correct here, and wrong in kikuchipy, because in EMsoft >= 5.0, the detector screen is viewed towards the sample, and xpc increases towards the right from the middle of the detector. Could you confirm that it's the EMsoft v5 convention you implemented?Should close #3.