-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create guide_streamlit.rst #1847
base: main
Are you sure you want to change the base?
Conversation
Thanks for your Guide! Please check the style guide: Don't mention additional document roots. Keep it simple. Don't use subfolders. Always use the standard document root ~/html. Always assume the document root is empty. |
adjusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! A few things left to change.
Oh and you can check a preview of your guide here, there's some blocks broken: https://deploy-preview-1847--uberlab.netlify.app/guide_streamlit/
|
||
After creating the configuration, tell :manual:`supervisord <daemons-supervisord>` to refresh its configuration and start the service: | ||
|
||
:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
.. include:: includes/supervisord.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Add Web Backend | ||
=============== | ||
|
||
.. code-block:: console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use:
.. note::
Streamlit is running on port 8501.
.. include:: includes/web-backend.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
|
||
.. tag_list:: | ||
|
||
Streamlit_ is a high-level Python Web framework focussing on data visualization. This guide is based on the :lab:`Django <guide_django>` guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's based on the Django Guide. I gave you the Django Guide as an example for another Python based guide, no need to mention it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used that file as a starting point, so quite some of the text in this guide are copied from there, so I find it important to quote the source.
I added your proposals. If more modifications are needed, feel free to directly apply them. I think that would be much faster than ping pong ;-) |
Based on Django guide, setup using non-root document root, as this way my use case.