Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added settings for max volumetric flow rate #14452

Closed
wants to merge 4 commits into from
Closed

Conversation

mjc-506
Copy link

@mjc-506 mjc-506 commented Feb 1, 2023

Description

Added settings for max volumetric flow rate

This fixes #5248 (together with another PR for CuraEngine)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

A new "Max filament flow rate" setting has been added, defaulting to 0.0 (no effect). Setting this to (say) 10mm3/sec to suit a particular extruder reduces the print head velocity to remain within this limit (especially useful with dymanic layer heights, or changing line widths etc).

Slicing STLs with this PR (and the CuraEngine one) results in slightly different Gcodes with different velocities, respecting the limit set.

Test Configuration:

  • Operating System: Linux
  • Cura 5.30 git
  • CuraEngine 5.30 git

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • [NA] I have uploaded any files required to test this change

@ghost
Copy link

ghost commented Feb 9, 2023

Thanks for putting in the work! Max VMS is one of my main requirements on a slicer since switching to a CHT nozzle, but I really want to go back to cura!

I'll figure out how to compile cura and test this PR.

Copy link
Contributor

@casperlamboo casperlamboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contribution looks good! have some minor remarks, if possible please review them yourself as well.

resources/definitions/fdmprinter.def.json Outdated Show resolved Hide resolved
resources/definitions/fdmprinter.def.json Outdated Show resolved Hide resolved
mjc-506 and others added 2 commits March 26, 2023 18:52
Use Unicode for cubic notation

Co-authored-by: Casper Lamboo <[email protected]>
Less rambling description!

Co-authored-by: Casper Lamboo <[email protected]>
@casperlamboo
Copy link
Contributor

See reply at Ultimaker/CuraEngine#1814 (comment)

Hi @mjc-506 sorry for taking this long to get back to you. We have had quite some internal discussions about this feature, and unfortunately we have decided to take a different approach.

We are afraid that, when using this new feature, the print behavior will become unpredictable. Instead we want to introduce a new feature that gives the user more insight whether flow jumps are violated, and can consequently change settings to make sure flow stays within an acceptable range.

Hope you understand our decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit extruder feedrate for printing and retraction
2 participants