Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.14.1 - add bytes32 non-null terminator logging #798

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Jan 15, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    chore

  • What is the current behavior? (You can also link to an open issue here)
    we don't know which token had non-null terminator runtime error

  • What is the new behavior (if this is a feature change)?
    log it so that we know

  • Other information:

Copy link
Member Author

jsy1218 commented Jan 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jsy1218 jsy1218 marked this pull request as ready for review January 15, 2025 19:00
@jsy1218 jsy1218 requested a review from a team as a code owner January 15, 2025 19:00
@graphite-app graphite-app bot requested review from cgkol and xrsv January 15, 2025 19:01
Copy link

graphite-app bot commented Jan 15, 2025

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (01/15/25)

3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@jsy1218 jsy1218 merged commit 0661027 into main Jan 15, 2025
21 of 31 checks passed
Copy link
Member Author

jsy1218 commented Jan 15, 2025

Merge activity

  • Jan 15, 4:56 PM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants