rename Snaps #535
Closed
rename Snaps #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Mar 27, 2024
test/PoolManager.t.sol
Outdated
| modifyLiquidityRouter.modifyLiquidity{value: 1 ether}(nativeKey, LIQ_PARAMS, ZERO_BYTES); | ||
| snapEnd(); | ||
| } | ||
|
|
||
| function test_removeLiquidity_withNative_gas() public { | ||
| snapStart("removeLiquidity with native token"); | ||
| snapStart("PoolManager.removeLiquidityWithNativeToken"); |
There was a problem hiding this comment.
I think it would be better to go
ContractName.functionName_extraNotes
e.g.
PoolManager.removeLiquidity_withNative
PoolManager.swap_simple
PoolManager.collectProtocolFees_withNative
hensha256
reviewed
Mar 27, 2024
test/DynamicFees.t.sol
Outdated
| @@ -142,7 +142,7 @@ contract TestDynamicFees is Test, Deployers, GasSnapshot { | |||
| vm.expectEmit(true, true, true, true, address(manager)); | |||
| emit Swap(key.toId(), address(swapRouter), -100, 98, 79228162514264329749955861424, 1e18, -1, 123); | |||
|
|
|||
| snapStart("update dynamic fee in before swap"); | |||
| snapStart("DynamicFees.updateDynamicSwapFee_beforeSwap"); | |||
There was a problem hiding this comment.
Suggested change
| snapStart("DynamicFees.updateDynamicSwapFee_beforeSwap"); | |
| snapStart("DynamicFees.swap_updateDynamicSwapFeeInBeforeSwap"); |
hensha256
reviewed
Mar 27, 2024
test/PoolManager.t.sol
Outdated
| @@ -566,7 +566,7 @@ contract PoolManagerTest is Test, Deployers, GasSnapshot { | |||
| PoolSwapTest.TestSettings memory testSettings = | |||
| PoolSwapTest.TestSettings({withdrawTokens: true, settleUsingTransfer: true, currencyAlreadySent: false}); | |||
|
|
|||
| snapStart("simple swap"); | |||
| snapStart("PoolManager.simpleSwap"); | |||
There was a problem hiding this comment.
Suggested change
| snapStart("PoolManager.simpleSwap"); | |
| snapStart("PoolManager.swap_simple"); |
hensha256
reviewed
Mar 27, 2024
test/PoolManager.t.sol
Outdated
| @@ -578,7 +578,7 @@ contract PoolManagerTest is Test, Deployers, GasSnapshot { | |||
| PoolSwapTest.TestSettings memory testSettings = | |||
| PoolSwapTest.TestSettings({withdrawTokens: true, settleUsingTransfer: true, currencyAlreadySent: false}); | |||
|
|
|||
| snapStart("simple swap with native"); | |||
| snapStart("PoolManager.simpleSwap_withNative"); | |||
There was a problem hiding this comment.
Suggested change
| snapStart("PoolManager.simpleSwap_withNative"); | |
| snapStart("PoolManager.swap_simpleWithNative"); |
snreynolds
reviewed
Apr 18, 2024
|
@snreynolds done! |
|
Hello @snreynolds @hensha256 Request to have this merged. Thanks. |
|
hi thanks for the suggestion, weve moved our snapshots to foundry's native snapshots so the PR is very stale we dont intend to introduce new bytecode changes so there isnt an urgency for standardizing the snapshot naming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
#390
Description of changes
Renaming the snapshots according to #390 (standardize snapshot names (no spaces, maybe something like : testFile.testName)