Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test code #679

Closed
wants to merge 5 commits into from
Closed

Conversation

havi-kim
Copy link
Contributor

@havi-kim havi-kim commented May 20, 2024

Related Issue

Which issue does this pull request resolve?
#390 Test suite improvements

Description of changes

I respect your codebase. However, I believe maintaining the test code might become challenging in the future. Therefore, I would like to propose some improvements to enhance maintainability.

The main points of the changes are as follows:

Improve Maintainability

  • Separate reusable functions
  • Separate Test Data
  • Enhance readability by applying the AAA pattern

Separate Unit Tests and Integration Tests

  • Unit tests should focus on minimal functionality according to the Single Responsibility Principle
  • Integration tests should continue to be based on the existing Deployer setup
  • Add unit tests for internal functions using inheritance

Additionally, I plan to keep all existing tests while adding some missing tests. I have refactored a few tests as examples. If you find these changes acceptable, I would like to proceed with improving the rest of the tests.

@havi-kim
Copy link
Contributor Author

I am closing this pull request as I believe the proposed changes may not be necessary at this time. Thanks.

@havi-kim havi-kim closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant