remove connection id for now

Unleash · Jan 24, 2025 · 5c69b7e · 5c69b7e
1 parent 78b8103
commit 5c69b7e
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 27 deletions.
diff --git a/src/Client/DefaultRegistrationService.php b/src/Client/DefaultRegistrationService.php
@@ -66,8 +66,7 @@ public function register(iterable $strategyHandlers): bool
 
         $request = $request
             ->withHeader('x-unleash-appname', $this->configuration->getAppName())
-            ->withHeader('x-unleash-sdk', $this->sdkName . ':' . $this->sdkVersion)
-            ->withHeader('x-unleash-connection-id', $this->configuration->getConnectionId());
+            ->withHeader('x-unleash-sdk', $this->sdkName . ':' . $this->sdkVersion);
 
         try {
             $response = $this->httpClient->sendRequest($request);

diff --git a/src/Configuration/UnleashConfiguration.php b/src/Configuration/UnleashConfiguration.php
@@ -22,8 +22,6 @@
 
 final class UnleashConfiguration
 {
-    private string $connectionId;
-
     /**
      * @param array<string,string> $headers
      */
@@ -49,7 +47,6 @@ public function __construct(
         private MetricsBucketSerializer $metricsBucketSerializer = new DefaultMetricsBucketSerializer(),
     ) {
         $this->contextProvider ??= new DefaultUnleashContextProvider();
-        $this->connectionId = Uuid::v4();
     }
 
     public function getCache(): CacheInterface
@@ -303,15 +300,4 @@ public function setMetricsBucketSerializer(MetricsBucketSerializer $metricsBucke
 
         return $this;
     }
-
-    public function getConnectionId(): string
-    {
-        $connectionId = $this->getCache()->get(CacheKey::CONNECTION_ID, $this->connectionId);
-        return is_string($connectionId) ? $connectionId : $this->connectionId;
-    }
-
-    public function updateCachedConnectionId(): void
-    {
-        $this->getCache()->set(CacheKey::CONNECTION_ID, $this->connectionId);
-    }
 }
diff --git a/src/Enum/CacheKey.php b/src/Enum/CacheKey.php
@@ -14,6 +14,4 @@ final class CacheKey
     public const string REGISTRATION = 'unleash.client.metrics.registration';
 
     public const string FEATURES_RESPONSE = 'unleash.client.feature.response';
-
-    public const string CONNECTION_ID = 'unleash.client.connection.id';
 }
diff --git a/src/Repository/DefaultUnleashRepository.php b/src/Repository/DefaultUnleashRepository.php
@@ -162,7 +162,6 @@ private function setCache(array $features): void
         $cache = $this->configuration->getCache();
         $ttl = $this->configuration->getTtl();
         $cache->set(CacheKey::FEATURES, $features, $ttl);
-        $this->configuration->updateCachedConnectionId();
     }
 
     /**
@@ -525,8 +524,7 @@ private function fetchFeatures(): array
 
             $request = $request
                 ->withHeader('x-unleash-appname', $this->configuration->getAppName())
-                ->withHeader('x-unleash-sdk', $this->sdkName . ':' . $this->sdkVersion)
-                ->withHeader('x-unleash-connection-id', $this->configuration->getConnectionId());
+                ->withHeader('x-unleash-sdk', $this->sdkName . ':' . $this->sdkVersion);
 
             try {
                 $response = $this->httpClient->sendRequest($request);

diff --git a/src/UnleashBuilder.php b/src/UnleashBuilder.php
@@ -70,8 +70,6 @@ final class UnleashBuilder
 
     private ?string $appName = null;
 
-    private string $connectionId;
-
     private ?ClientInterface $httpClient = null;
 
     private ?RequestFactoryInterface $requestFactory = null;
@@ -134,8 +132,6 @@ public function __construct()
             $this->eventDispatcher = new EventDispatcher();
         }
 
-        $this->connectionId = Uuid::v4();
-
         $rolloutStrategyHandler = new GradualRolloutStrategyHandler(new MurmurHashCalculator());
         $this->strategies = [
             new DefaultStrategyHandler(),

diff --git a/tests/Client/DefaultRegistrationServiceTest.php b/tests/Client/DefaultRegistrationServiceTest.php
@@ -138,7 +138,6 @@ public function testRequestHeaders()
             ->setCache($this->getCache())
             ->setHeaders([
                 'Some-Header' => 'some-value',
-                'x-unleash-connection-id' => 'should not override',
             ])->setCache($this->getCache());
 
         $instance = new DefaultRegistrationService(
@@ -155,6 +154,5 @@ public function testRequestHeaders()
         self::assertSame('some-value', $request->getHeaderLine('Some-Header'));
         self::assertEquals('customAppName', $request->getHeaderLine('x-unleash-appname'));
         self::assertStringStartsWith('unleash-client-php:', $request->getHeaderLine('x-unleash-sdk'));
-        self::assertStringMatchesFormat('%s-%s-%s-%s-%s', $request->getHeaderLine('x-unleash-connection-id'));
     }
 }