Use a Set for id lookup (#1088)

VEuPathDB · May 21, 2024 · 7e97ee8 · 7e97ee8
1 parent b2458f0
commit 7e97ee8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/packages/libs/eda/src/lib/core/components/computations/plugins/correlation.tsx b/packages/libs/eda/src/lib/core/components/computations/plugins/correlation.tsx
@@ -534,13 +534,13 @@ function isEnabledInPicker({
 
     // Find all variables in any collection, then remove them from the
     // list of all variables to get a list of metadata variables.
-    const variablesInACollection = entities[0].collections?.flatMap(
-      (collection) => {
+    const variablesInACollection = new Set(
+      entities[0].collections?.flatMap((collection) => {
         return collection.memberVariableIds;
-      }
+      })
     );
     metadataVariables = entities[0].variables.filter((variable) => {
-      return !variablesInACollection?.includes(variable.id);
+      return !variablesInACollection.has(variable.id);
     });
   }
 

diff --git a/packages/libs/eda/src/lib/core/components/computations/plugins/correlationAssayMetadata.tsx b/packages/libs/eda/src/lib/core/components/computations/plugins/correlationAssayMetadata.tsx
@@ -411,13 +411,13 @@ function isEnabledInPicker({
 
     // Find all variables in any collection, then remove them from the
     // list of all variables to get a list of metadata variables.
-    const variablesInACollection = entities[0].collections?.flatMap(
-      (collection) => {
+    const variablesInACollection = new Set(
+      entities[0].collections?.flatMap((collection) => {
         return collection.memberVariableIds;
-      }
+      })
     );
     metadataVariables = entities[0].variables.filter((variable) => {
-      return !variablesInACollection?.includes(variable.id);
+      return !variablesInACollection.has(variable.id);
     });
   }