Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interim non-handling of date variables for bubble markers (but allows EdaDataService#309 to be merged) #453

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

bobular
Copy link
Member

@bobular bobular commented Aug 29, 2023

Compiles - not tested yet because the only back end with dates and map data is down at the mo.

Should provide the following (check off when tested)

  • date variables disabled from bubble marker variable picker
  • no malformed service payload errors
  • normal functioning of bubble markers for non-date variables

If there are any developers' saved user analyses with date variables, these may or may not work, but this is not an issue for actual beta users.

Testing would require a local back end from VEuPathDB/EdaDataService#309 running. I'm not expecting this for the PR review.

If/when approved, we should coordinate the back end merging with @dmgaldi

@bobular bobular changed the title Handle date variables for bubble markers Interim non-handling of date variables for bubble markers (but allows EdaDataService#309 to be merged) Aug 29, 2023
@bobular
Copy link
Member Author

bobular commented Oct 5, 2023

Note to self:
For testing with local(ish) back end (with dfalke-b.vectorbase wdk service), this will get me direct to the ticks and save a bit of time
https://localhost:3000/maps/DS_e18287e335/VVbYZ4P

@bobular
Copy link
Member Author

bobular commented Oct 5, 2023

Merged latest from main. Tested against local VEuPathDB/EdaDataService#309 back end. All working fine.

Note that this does NOT introduce date variable handling for bubble markers. This will come after the collections-related refactor.

@bobular bobular marked this pull request as ready for review October 5, 2023 16:51
@bobular bobular requested review from chowington and dmfalke October 5, 2023 16:51
Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to test this branch, using a local backend, but responses are taking way to long, and I'm getting errors I've never seen (Expected 6 columns but parsed 1 in line:2003-Desplaines-Valley-Mosquito-Abatemen).

The code compiles, so I will assume things will work better in a more capable environment.

@bobular
Copy link
Member Author

bobular commented Oct 19, 2023

I'm trying to test this branch, using a local backend, but responses are taking way to long, and I'm getting errors I've never seen (Expected 6 columns but parsed 1 in line:2003-Desplaines-Valley-Mosquito-Abatemen).

The code compiles, so I will assume things will work better in a more capable environment.

Was that a back end error?

@bobular bobular merged commit 193d026 into main Oct 19, 2023
1 check passed
@bobular bobular deleted the handle-date-bubbles branch October 19, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants