-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interim non-handling of date variables for bubble markers (but allows EdaDataService#309 to be merged) #453
Conversation
Note to self: |
Merged latest from main. Tested against local VEuPathDB/EdaDataService#309 back end. All working fine. Note that this does NOT introduce date variable handling for bubble markers. This will come after the collections-related refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to test this branch, using a local backend, but responses are taking way to long, and I'm getting errors I've never seen (Expected 6 columns but parsed 1 in line:2003-Desplaines-Valley-Mosquito-Abatemen
).
The code compiles, so I will assume things will work better in a more capable environment.
Was that a back end error? |
Compiles - not tested yet because the only back end with dates and map data is down at the mo.
Should provide the following (check off when tested)
If there are any developers' saved user analyses with date variables, these may or may not work, but this is not an issue for actual beta users.
Testing would require a local back end from VEuPathDB/EdaDataService#309 running. I'm not expecting this for the PR review.
If/when approved, we should coordinate the back end merging with @dmgaldi