a solution to prevent single click while double clicking #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobular
approved these changes
Nov 29, 2023
| @@ -335,7 +342,8 @@ export default function BoundsDriftMarker({ | |||
| position={position} | |||
| // new way to handle mouse events | |||
| eventHandlers={{ | |||
| click: (e: LeafletMouseEvent) => handleClick(e), | |||
| // debounce single click to be prevented when double clicking marker | |||
| click: (e: LeafletMouseEvent) => debounceSingleClick(e), | |||
There was a problem hiding this comment.
This would save a few bytes! (same for the other handlers)
Suggested change
| click: (e: LeafletMouseEvent) => debounceSingleClick(e), | |
| click: debounceSingleClick, |
There was a problem hiding this comment.
@bobular Thank you for your review and tests 👍 Yes they can be simplified as you noticed: thanks! I addressed your feedbacks and removed the console.log I made for test purpose.
moontrip
merged commit 64596db
into
multiple-marker-selection-simplified
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will possibly address the single click issue while double clicking a marker. Branched out from #588.