Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: new react runtime #902

Merged
merged 1 commit into from
Oct 7, 2024
Merged

BREAKING CHANGE: new react runtime #902

merged 1 commit into from
Oct 7, 2024

Conversation

SevereCloud
Copy link
Contributor

Устанавливаем новый рантайм, меняем поддержку реакта на ^18

@SevereCloud SevereCloud self-assigned this May 24, 2024
@SevereCloud SevereCloud mentioned this pull request May 24, 2024
Open
@github-actions GitHub Actions
Copy link

👀 Docs deployed

See the docs for this PR at https://vkcom.github.io/icons/pull/902/

@SevereCloud
Copy link
Contributor Author

size как-то не правильно сработал

@mendrew
Copy link
Contributor

mendrew commented May 24, 2024

size как-то не правильно сработал

Да, там теперь не хватает пересборки icons-sprite, так как многие зависимости поменялись, а результат сборки используется в icons-build.

Нужен yarn workspace @vkontakte/icons-sprite build перед запуском icons-build. Надо это, похоже в одну команду icons-build запихнуть, причём в отдельном PR, а то билд сыпется на мастере, который про изменения в этой ветке не узнает.

@mendrew mendrew mentioned this pull request Jun 3, 2024
Merged
@mendrew
Copy link
Contributor

mendrew commented Jun 3, 2024

@SevereCloud поменял вызов icons-build, чтобы size-limit не падал на этом PR
#909

Протестировал тут как раз с твоими изменениями: #910

@SevereCloud SevereCloud force-pushed the SevereCloud/BREAKING-CHANGE/new-react-runtime branch from 857558e to e09c413 Compare June 3, 2024 13:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 3.98 MB (-0.01% 🔽)
JS (gzip) 982.81 KB (-0.01% 🔽)
JS (brotli) 705.77 KB (-0.01% 🔽)
JS ES6 with Icon16Add only import (tree shaking) 5.39 KB (-5.33% 🔽)
SVG 3.82 MB (0%)

mendrew
mendrew approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💠

@SevereCloud SevereCloud force-pushed the SevereCloud/BREAKING-CHANGE/new-react-runtime branch from e09c413 to 6327712 Compare September 9, 2024 09:40
@SevereCloud SevereCloud added this to the v3.0.0 milestone Sep 9, 2024
@SevereCloud SevereCloud force-pushed the SevereCloud/BREAKING-CHANGE/new-react-runtime branch from 6327712 to b6be8f1 Compare October 1, 2024 09:30
@SevereCloud SevereCloud force-pushed the SevereCloud/BREAKING-CHANGE/new-react-runtime branch from b6be8f1 to 9c6faf7 Compare October 7, 2024 09:33
@SevereCloud SevereCloud changed the base branch from master to v3-dev October 7, 2024 09:34
@SevereCloud SevereCloud merged commit 8b7eca2 into v3-dev Oct 7, 2024
5 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/BREAKING-CHANGE/new-react-runtime branch October 7, 2024 09:48
SevereCloud added a commit that referenced this pull request Dec 3, 2024
@SevereCloud
BREAKING CHANGE: new react runtime (#902)
d17dacd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@mendrew mendrew mendrew approved these changes

Assignees

@SevereCloud SevereCloud

Labels
None yet
Projects
VKUI
Archived in project
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SevereCloud @mendrew @inomdzhon