Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recursion depth limit in to_array_debug() #709

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

drdzyk
Copy link
Contributor

@drdzyk drdzyk commented Dec 20, 2022

Closes #701
Subj. Depends on kphp-polyfills' patch.

@drdzyk drdzyk force-pushed the seismont/limit-recursion-in-to-array branch from a8f1122 to 7aa43dd Compare December 21, 2022 09:32
@tolk-vm
Copy link
Contributor

tolk-vm commented Dec 21, 2022

Could you please mention #701 in description, as this PR solves it?

@drdzyk
Copy link
Contributor Author

drdzyk commented Dec 22, 2022

Could you please mention #701 in description, as this PR solves it?

Sure, I'm going to do so after merging this PR in master

@tolk-vm tolk-vm added this to the next milestone Dec 23, 2022
@DrDet DrDet self-requested a review January 24, 2023 09:58
@tolk-vm tolk-vm removed this from the next milestone Jan 24, 2023
@tolk-vm
Copy link
Contributor

tolk-vm commented Jan 24, 2023

Will merge after issues in polyfills are resolved and that PR is merged

@tolk-vm tolk-vm added the small fix When it's not an huge enhancement label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small fix When it's not an huge enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix instance_to_array behavior on recursive classes
2 participants