linter: new rule for declare(strict_types) #1228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hidanio
commented
Jul 25, 2024
•
Hidanio
commented
- added new linter rule: declareStrictTypes can not be "0"
- added quickFix for declareStrictTypes
- added new linter rule: lack of declare(strict_types=1) section
- added quickFix for lack of declare(strict_types=1) section
added quickFix for declareStrictTypes added test
…) section new rules for .gitignore new tests refactored warnings
Hidanio
force-pushed
the
linter_declare_strict
branch
from
64b7ffb to
f83f419
Compare
| strictMixed bool | ||
| strictTypes bool | ||
| strictMixed bool | ||
| declareSection bool |
There was a problem hiding this comment.
I propose to do it differently. We have an ir.Root node that describes the entire file. Essentially, we can check if there is an ir.DeclareStmt at its level, and if there is, show an error.
see block.go
| @@ -25,6 +25,24 @@ func addBuiltinCheckers(reg *CheckersRegistry) { | |||
| After: `$s = strip_tags($s, '<br>')`, | |||
| }, | |||
|
|
|||
| { | |||
| Name: "notStrictTypes", | |||
There was a problem hiding this comment.
Let's split the checks into two different MRs, shall we?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.