MA-19777: add height_type & orientation fields #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarkin13
reviewed
Oct 2, 2024
| @@ -1061,8 +1073,10 @@ export type VKWebAppShowBannerAdResponse = { | |||
| banner_width: number; | |||
| banner_height: number; | |||
| banner_location: BannerAdLocation; | |||
| banner_align: BannerAdAlign; | |||
| banner_align?: BannerAdAlign; | |||
There was a problem hiding this comment.
в описание про новые поля, это валидное исправление?
There was a problem hiding this comment.
да, banner_align не всегда возвращается
Yarkin13
previously approved these changes
Oct 2, 2024
povarok
force-pushed
the
vasiliykomarov/task/add-banner-properties/MA-19777
branch
from
34b4a94 to
84d13b5
Compare
Yarkin13
previously approved these changes
Oct 3, 2024
Yarkin13
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание проблемы
Описание решения
добавляем новые поля для метода VKWebAppShowBannerAd
Способ проверки с шагами
Обратная совместимость
Скриншоты