Add serialization of OathGames to save strings.
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now allows transferring a chronicle from the real world to TTS: manually construct an `OathGame` object and then use `serializOathGame` to get a string that can be loaded into TTS. For every TTS save string, we can now parse the string into an `OathGame` object and then serialize back to the original string. `inverseParse.js` was added as a mini test suit to verify this property against known strings. Some small bugs in the parser were fixed in the process: - Suit order was being parsed incorrectly. - Previous game winner was always Brown and did not support Purple in enum. - Previous game winner and exile status were looking at the wrong offsets.
seiyria
approved these changes
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now allows transferring a chronicle from the real world to TTS: manually construct an
OathGameobject and then useserializOathGameto get a string that can be loaded into TTS.For every TTS save string, we can now parse the string into an
OathGameobject and then serialize back to the original string.inverseParse.jswas added as a mini test suit to verify this property against known strings.Some small bugs in the parser were fixed in the process: