Introduce ResultExpr #216
Draft
Introduce ResultExpr #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a wrapper type that allows to encode the LHS (the result) as well as the LHS (the expression) of an equation. Explicitly tracking the LHS is required in order to access information about which indices are paired together during spin integration (the approach abusing the symmetrizer operators breaks down for results that have mixed index spaces in the bra and/or ket). In the future, this class may solve as a nucleation point for a framework to store arbitrary metadata about a given expression because it is not nestable (contrary to Expr objects).
evaleev
reviewed
Jul 25, 2024
| class Tensor; | ||
| class Variable; | ||
|
|
||
| class ResultExpr { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wrapper type that allows to encode the LHS (the result) as well as the LHS (the expression) of an equation. Explicitly tracking the LHS is required in order to access information about which indices are paired together during spin integration (the approach abusing the symmetrizer operators breaks down for results that have mixed index spaces in the bra and/or ket).
In the future, this class may solve as a nucleation point for a framework to store arbitrary metadata about a given expression because it is not nestable (contrary to Expr objects).