Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Reintegrate Framework V2 into Framework V1 #14

Merged
merged 18 commits into from
Feb 15, 2024
Merged

Conversation

pmbittner
Copy link
Member

This PR reintegrates all changes and additions from V2 of the framework back to V1. Apart from file movement and module renaming, notable differences are

  • generalisation of function languages to allow for a parameterised expression type and output type. We need this for variability languages whose expressions and variants are parameterised in a domain. Previously, expressions and variants would have to be fixed to a domain before reusing the function language definitions. This however caused weaker forms of completeness and incompleteness, so I decided to add the domain as a type parameter to function languages. This feels a bit odd but works fine with function language. It also introduces some annoying fiddly problems with implicit parameters. Feedback welcome.
  • new definitions for soundness and completeness: Both theorems are now formulated on function languages. As of now, they feel a bit clunky but its the best solution I could came up with so far that is still compatible with variability languages.
  • reformulation of the old languages (CCC, BCC, OC) in terms of the new framework and constructors. Only for option calculus, we cannot reuse any variability constructors yet.

@pmbittner pmbittner added the enhancement New feature or request label Dec 6, 2023
@pmbittner pmbittner self-assigned this Dec 6, 2023
@pmbittner pmbittner changed the base branch from funlang to develop January 17, 2024 13:46
@pmbittner pmbittner merged commit 004faf8 into develop Feb 15, 2024
1 check passed
@pmbittner pmbittner deleted the wedding branch February 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant