Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with EHRMamba generation #56

Merged
merged 12 commits into from
Jun 19, 2024
Merged

Fix issues with EHRMamba generation #56

merged 12 commits into from
Jun 19, 2024

Conversation

Adibvafa
Copy link
Member

PR Type

Fix

Short Description

Fix issues with EHRMamba generation

Tests Added

None

@Adibvafa Adibvafa self-assigned this Jun 17, 2024
@Adibvafa Adibvafa requested a review from amrit110 June 17, 2024 15:36
@Adibvafa Adibvafa added the bug Something isn't working label Jun 17, 2024
@Adibvafa Adibvafa marked this pull request as draft June 17, 2024 15:39
@Adibvafa Adibvafa marked this pull request as ready for review June 18, 2024 00:00
@Adibvafa
Copy link
Member Author

Adibvafa commented Jun 18, 2024 •
edited
Loading

@amrit110 This PR is now ready for review.
Is it possible to remove [odyssey/models/ehr_mamba/mamba_utils.py] from the docstring check so I can push the fixed version into main? (It should not have "----" after return statement.)

@amrit110 amrit110 merged commit 691f3bd into main Jun 19, 2024
2 of 4 checks passed
@amrit110 amrit110 deleted the feature/mamba branch June 19, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrit110 amrit110 amrit110 approved these changes

Assignees

@Adibvafa Adibvafa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adibvafa @amrit110