[VEN-2975] Chaos labs recommendations (December 12th, 2024) #2596
Triggered via pull request
December 30, 2024 09:55
Status
Success
Total duration
19m 44s
Artifacts
–
ci.yaml
on: pull_request
Lint
1m 32s
Test
19m 34s
Deploy
4m 36s
export-deployments
1m 32s
Annotations
11 warnings
export-deployments
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Lint:
contracts/Comptroller.sol#L50
Immutable variables name are set to be in capitalized SNAKE_CASE
|
Lint:
contracts/Comptroller.sol#L503
Variable "redeemAmount" is unused
|
Lint:
contracts/Comptroller.sol#L503
Variable "redeemTokens" is unused
|
Lint:
contracts/Comptroller.sol#L986
Use Custom Errors instead of require statements
|
Lint:
contracts/Comptroller.sol#L998
Use Custom Errors instead of require statements
|
Lint:
contracts/Comptroller.sol#L999
Use Custom Errors instead of require statements
|
Lint:
contracts/Comptroller.sol#L1074
Use Custom Errors instead of require statements
|
Lint:
contracts/Comptroller.sol#L1102
Use Custom Errors instead of require statements
|
Lint:
contracts/Comptroller.sol#L1136
Use Custom Errors instead of require statements
|
Lint:
contracts/Comptroller.sol#L1160
Use Custom Errors instead of require statements
|