Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging messages, add guaranteed logging and throw for fatal errors #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uniflare
Copy link
Contributor

@uniflare uniflare commented Jun 7, 2022

!B (Logging) Repair log messages not showing the actual message and fix-up newlines

  • Add LOG_G for guaranteed logging via stderr on Linux, or OutputDebugString on Windows
  • Prevent infinite loop by using LOG_G during storage init (used to find a suitable log file location)
  • Throw runtime_error for fatal errors (prevents extension loading in an incorrect state)

I didn't take care with the logging changes, it fixed the error, however i neglected the argument changes so the actual message from the call-site is never printed :/. Couple extras also.

…ix-up newlines

 - Add LOG_G for guaranteed logging via stderr on Linux, or OutputDebugString on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant