Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Boss #53

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement Boss #53

wants to merge 9 commits into from

Conversation

kimchiloof
Copy link
Contributor

@kimchiloof kimchiloof commented Jul 28, 2024

ClickUp ticket link

Move boss to new scripts

Implementation description

Implements cactus boss scripts into scenes/demos/Test New Boss

Adds:

  • Boss health bar
  • Boss contact and ranged attacks
    Fixes:
  • Enemy health bar (also adds a outline if wanted) - will need to replace with the new prefab to use

Steps to test

  1. Open the Test New Boss scene and play around with boss
  2. Does it feel like reasonable attacks? Anything else to add/change
  3. Verify boss health bar looks good at top of screen, enemy health bar follows boss

What should reviewers focus on?

What kind of health bar is better, outline or no outline?

Any other attacks to add/change/balance?

Checklist

  • My PR name is descriptive
  • My commit messages are descriptive. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • My code is organized, and commented and documented so that another dev can understand what I did

Copy link
Contributor

@gracexuwt gracexuwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice! Code is easy to follow and the vacuum attack is a cool mechanic.

The boss health bar works, though maybe later we could locate it at the bottom since it may be confused with the player's health bar. The outlined health bar looks better in my opinion.

The boss was quite difficult to defeat using melee attacks (I used ranged attacks from a distance instead). That might be due to boss melee animations not being implemented yet so we couldn't predict/see its moves, but not a big problem since we could build the boss fight arena so that the player can hide and strategically shoot the boss with ranged attacks.

If you would like to make further changes, please do so! Maybe you could nerf the boss a bit (melee attack damage is high, player could barely approach it especially with the vacuum attacks), but otherwise the boss is very well done. Feel free to merge to main anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants