Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prerender ClientHints-related algo #239

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

Clqsin45
Copy link
Contributor

The "Client Hints Infrastructure" specification updates the logic handling CH Cache[1], so this PR updates the logic on the prerender2 side accordingly to be consistent with the CH specification.

Including:

  1. processing a request:
  • Before: the processed hintSet is the union of prerender navigable's accept-CH cache and the global accept-CH cache.
  • After: prerender navigable's accept-ch cache will override the global one.
  1. update prerender navigable's accept-ch cache:
  • Before: prerender navigable's accept-ch cache was set to the union of global accept-CH cache and the tokens specified by the 'Accept-CH' header.
  • After: prerender navigable's accept-ch cache will be set to the tokens specified by the 'Accept-CH' header, because they are the newest.

[1] WICG/client-hints-infrastructure#135

Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work; thank you! I'll wait to merge this until after #237 lands so we can have a series of green builds on the main branch :)

@github-actions
Copy link

Preview:

@domenic domenic merged commit 1903530 into WICG:main Jan 18, 2023
@Clqsin45
Copy link
Contributor Author

Thank you for reviewing!! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants