rename wasi:blobstore/blobstore to wasi:blob/store and other tidy up
#26
+54
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit renames the interface from `wasi:blobstore/blobstore` to `wasi:blob/store` and updates the `world` file to reflect the change. it also moved the `container` interface to the `store` interface. Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
Adds documentation to the `wasi:blob/imports` world and delete the top comment in `wit/store.wit` as it is not needed. Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
|
Would love to get your thoughts on this one @thomastaylor312 |
thomastaylor312
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
I love condensing this down to a single interface. The rename is a bit weird to me as the tech is generally called blobstore and we already renamed this once, but I also get that wasi:blobstore/store stutters. With that said, this is the definition of a bikeshed, so I don't want to block on it. If you feel like this is the best name, I don't have an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasi:blobstore/blobstoretowasi:blob/storewasi:blob/importsWorldwasi:blob/containerto the inside ofwasi:blob/store@thomastaylor312 @lukewagner
discussion: I would like to document the changes in a CHANGELOG file that follows keep a changelog