-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wasm-component-ld #506
Update wasm-component-ld #506
Conversation
Pulls in a fix for bytecodealliance/wasmtime#10058 in the adapters that are used by default.
I've updated the version of Wasmtime used in CI due to bytecodealliance/actions#14 of what I suspect was causing the initial failure in CI for the first commit. |
Looks like this is failing on Ubuntu 24.04, the new default of `ubuntu-latest`, so downgrade it to have it get fixed in a separate PR.
The last failure was due to:
which means that the I might send a second PR in the future to update the Linux containers to |
Hm ok now those failures are due to Wasmtime needing to be 23+ to run tests for components now (since WASI versions are now 0.2.3 instead of 0.2.0). I've pushed an update of the base image from Ubuntu 18.04 to 20.04 and I'll see what CI says... |
Ok looks like CI is green now. @pchickey (or someone else) mind signing off on the update of the Linux base images from 18.04 to 20.04 for ubuntu? This will increase the glibc requirement which means that the artifacts will require slightly newer linux distros to run. I'm not sure how to otherwise easily work around this at this time. |
I feel comfortable reviewing the wasm-component-ld bump but I haven't been in the trenches of linux/libc compat for a while to make that call, I'm going to tag in @abrown @sbc100 @sunfishcode (or others!) who have more experience in that front to sign off on that aspect |
Bumping from Ubuntu 18.04 to 20.04 sounds fine to me. |
IIRC, @sbc100 cared most about maintaining support for older images so that we knew the compatibility bounds. |
20.04 focal seem reasonable to me. We switch to that as our minimum a while back in emscripten. |
Ok thanks all! I'm going to go ahead and merge this then 👍 |
Pulls in a fix for bytecodealliance/wasmtime#10058 in the adapters that are used by default.