Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add -P flag to info subcommand to get metadata about multiple patterns at the same time + remove --type flag #142

Merged
merged 13 commits into from
Dec 8, 2024

Conversation

iTrooz
Copy link
Collaborator

@iTrooz iTrooz commented Dec 7, 2024

No description provided.

@iTrooz
Copy link
Collaborator Author

iTrooz commented Dec 7, 2024

Expected use case: use in https://github.com/werWolv/WerwolvAPI to parse patterns metadata quicker.
From a test I've done, this reduce the time to parse all patterns metadata from 5.9s to 2.8s

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 1.01010% with 98 lines in your changes missing coverage. Please review.

Project coverage is 26.78%. Comparing base (d387be8) to head (8a5cdbf).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cli/source/helpers/info_utils.cpp 0.00% 49 Missing ⚠️
cli/source/subcommands/info.cpp 2.00% 45 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   26.85%   26.78%   -0.07%     
==========================================
  Files         139      140       +1     
  Lines       11128    11158      +30     
  Branches     6082     6092      +10     
==========================================
+ Hits         2988     2989       +1     
- Misses       5312     5340      +28     
- Partials     2828     2829       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iTrooz iTrooz changed the title add massinfo subcommand to get metadata about multiple patterns at the same time feat: add massinfo subcommand to get metadata about multiple patterns at the same time Dec 7, 2024
@iTrooz iTrooz changed the title feat: add massinfo subcommand to get metadata about multiple patterns at the same time feat: add -p flag to info subcommand to get metadata about multiple patterns at the same time Dec 8, 2024
@iTrooz iTrooz changed the title feat: add -p flag to info subcommand to get metadata about multiple patterns at the same time feat: add -p flag to info subcommand to get metadata about multiple patterns at the same time + remove --type flag Dec 8, 2024
@iTrooz iTrooz changed the title feat: add -p flag to info subcommand to get metadata about multiple patterns at the same time + remove --type flag feat: add -P flag to info subcommand to get metadata about multiple patterns at the same time + remove --type flag Dec 8, 2024
@iTrooz iTrooz merged commit a328286 into WerWolv:master Dec 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants