Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#111 for prod #113

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Feature/#111 for prod #113

merged 3 commits into from
Nov 20, 2024

Conversation

Oodls
Copy link
Member

@Oodls Oodls commented Nov 19, 2024

๐Ÿ“œ Pull Request ์„ค๋ช…

์ด PR์€ [๋ฌธ์ œ ์„ค๋ช… ๋˜๋Š” ๊ธฐ๋Šฅ ์„ค๋ช…] ์ž…๋‹ˆ๋‹ค.

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ

โœจ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ๋ฐฐํฌ์šฉ ๋„์ปคํŒŒ์ผ ์ž‘์„ฑ

  • properties ํŒŒ์ผ์— target url, target port์ถ”๊ฐ€

  • ๊ธฐํƒ€ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ url ๋ฐ ํฌํŠธ ๋ณ€์ˆ˜๋กœ ๋ณ€๊ฒฝ,cors ์„ค์ •๋„ ๋ณ€์ˆ˜๋กœ ๋ณ€๊ฒฝ

  • ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ์ž‘๋™ํ•˜๋Š”์ง€ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

  • ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ๋ฉ”์„ธ์ง€๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ” ์ถ”๊ฐ€ ์ •๋ณด

  • [์ถ”๊ฐ€์ ์ธ ์ •๋ณด ๋˜๋Š” ์ฃผ์˜ ์‚ฌํ•ญ]

@Oodls Oodls added the enhancement New feature or request label Nov 19, 2024
@Oodls Oodls requested a review from soljjang777 November 19, 2024 08:42
@Oodls Oodls self-assigned this Nov 19, 2024
soljjang777
soljjang777 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@soljjang777 soljjang777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค

@soljjang777 soljjang777 merged commit 5ff529a into develop Nov 20, 2024
1 check passed
@soljjang777 soljjang777 deleted the feature/#111-for-prod branch November 20, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soljjang777 soljjang777 soljjang777 approved these changes

Assignees

@Oodls Oodls

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oodls @soljjang777