Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#77 admin knowhow #91

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Fix/#77 admin knowhow #91

merged 6 commits into from
Nov 13, 2024

Conversation

2oo1s
Copy link
Member

@2oo1s 2oo1s commented Nov 13, 2024

๐Ÿ“œ Pull Request ์„ค๋ช…

์ด PR์€ ์ง€ํ˜œ ๊ด€๋ฆฌ ๊ด€๋ จ ์ˆ˜์ •์ž…๋‹ˆ๋‹ค.

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ

โœจ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • KnowhowDetailDTO์— userName ์ถ”๊ฐ€

โœ… ํ™•์ธ ์‚ฌํ•ญ

  • ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ์ž‘๋™ํ•˜๋Š”์ง€ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ๋ฉ”์„ธ์ง€๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ” ์ถ”๊ฐ€ ์ •๋ณด

@2oo1s 2oo1s added the fix Fix something label Nov 13, 2024
@2oo1s 2oo1s self-assigned this Nov 13, 2024
haewoni
haewoni approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@haewoni haewoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒ์Šˆ ์นผํ‡ด ๊ธฐ์›ํ•ฉ๋‹ˆใ„ทใ… ~

@haewoni haewoni merged commit ba98e3e into develop Nov 13, 2024
1 check passed
@2oo1s 2oo1s deleted the fix/#77-admin-knowhow branch November 13, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haewoni haewoni haewoni approved these changes

@soljjang777 soljjang777 Awaiting requested review from soljjang777

@cshharry cshharry Awaiting requested review from cshharry

@Oodls Oodls Awaiting requested review from Oodls

Assignees

@2oo1s 2oo1s

Labels
fix Fix something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2oo1s @haewoni