Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hash of SALT to healthcheck, for change detection #853

Open
wants to merge 2 commits into
base: rc-v0.5.1
Choose a base branch
from
Open

add hash of SALT to healthcheck, for change detection #853

wants to merge 2 commits into from

Conversation

eschultink
Copy link
Member

@eschultink eschultink commented Jan 25, 2025 •
edited
Loading

Features

  • add hash of SALT to health check, for change detection

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes? no
  • security risk that somehow reveals something about the SALT; but see comments; should be very safe in practice due to sufficiently large and random potential set of SALTs; but salted SALT for some extra protection

@eschultink eschultink self-assigned this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlorper jlorper Awaiting requested review from jlorper

@aperez-worklytics aperez-worklytics Awaiting requested review from aperez-worklytics

At least 1 approving review is required to merge this pull request.

Assignees

@eschultink eschultink

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eschultink