S175 initial version #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfq
commented
May 31, 2024
aperez-worklytics
approved these changes
Jun 3, 2024
Co-authored-by: aperez-worklytics <[email protected]>
- Add extra settings (bulk and github) - Make script filename variable (multiple connections to the same source) - Delete `kind` setting (AWS context given)
- Missing tenant API host - Define extra settings
Optional attributes (`module_variable_optional_attrs`) was an experimental feature in 1.1.x - 1.2.x versions, and our official Psoxy docs explicitly states that Terraform 1.3.x is a requirement
|
@jlorper this is ready; fully tested (see https://github.com/Worklytics/evalengin/pull/6934) |
jlorper
reviewed
Oct 21, 2024
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| terraform_version: [ '~1.5.0', '~1.6.0', '~1.7.0', 'latest'] # in theory, we go down to 1.3, but I think that's overkill for lint |
There was a problem hiding this comment.
starting rc-0.5 this is >= 1.6
https://github.com/Worklytics/psoxy/blob/rc-v0.5.0/.github/workflows/ci-terraform-modules.yaml
So adapt everywhere please
Comment on lines
+11
to
+12
| should be to create the actual connection in the [Data Sources] section of the Worklytics Web App. These submodules | ||
| provide a way to automate this process. |
There was a problem hiding this comment.
Suggested change
| should be to create the actual connection in the [Data Sources] section of the Worklytics Web App. These submodules | |
| provide a way to automate this process. | |
| should be to create the actual connection in the [Data Sources] section of the Worklytics Web App, either manually following the instructions in the TO-DO files, or automatically with a script that is produced by these sub-modules. |
not totally sold on this... what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See task for details (comments on modules structure): Tenant API: Terraform AWS modules.