Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Graceful shutdown #1801

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

kuznetsss
Copy link
Collaborator

For #442. This is a WIP PR containing current state of graceful shutdown.

@kuznetsss kuznetsss force-pushed the 442_Graceful_shutdown_with_new_server branch from 77db7fe to 7062d40 Compare December 20, 2024 17:13
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some small suggestions. Looks pretty good 👍

src/app/Stopper.hpp Show resolved Hide resolved
src/etl/impl/SubscriptionSource.cpp Outdated Show resolved Hide resolved
src/etl/impl/SubscriptionSource.cpp Outdated Show resolved Hide resolved
src/etl/impl/SubscriptionSource.cpp Outdated Show resolved Hide resolved
src/util/StopHelper.cpp Outdated Show resolved Hide resolved
src/util/StopHelper.cpp Show resolved Hide resolved
src/web/ng/Server.cpp Show resolved Hide resolved
src/app/ClioApplication.cpp Outdated Show resolved Hide resolved
@kuznetsss kuznetsss marked this pull request as ready for review January 9, 2025 17:50
{
connectionHandler_.stop(yield);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be covered by test.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 69.71831% with 43 lines in your changes missing coverage. Please review.

Project coverage is 71.42%. Comparing base (590c07a) to head (baa6727).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/app/Stopper.hpp 10.52% 0 Missing and 17 partials ⚠️
src/etl/impl/SubscriptionSource.cpp 73.33% 4 Missing and 4 partials ⚠️
src/etl/ETLService.hpp 12.50% 7 Missing ⚠️
src/web/ng/Server.cpp 72.22% 4 Missing and 1 partial ⚠️
src/app/ClioApplication.cpp 0.00% 3 Missing ⚠️
src/app/Stopper.cpp 90.90% 0 Missing and 1 partial ⚠️
src/etl/impl/SourceImpl.hpp 66.66% 0 Missing and 1 partial ⚠️
src/web/ng/impl/ConnectionHandler.cpp 96.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1801      +/-   ##
===========================================
- Coverage    71.45%   71.42%   -0.03%     
===========================================
  Files          321      325       +4     
  Lines        13227    13321      +94     
  Branches      6737     6789      +52     
===========================================
+ Hits          9451     9515      +64     
- Misses        1958     1966       +8     
- Partials      1818     1840      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants