-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Graceful shutdown #1801
base: develop
Are you sure you want to change the base?
feat: Graceful shutdown #1801
Conversation
…tdown_with_new_server
…tdown_with_new_server
77db7fe
to
7062d40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some small suggestions. Looks pretty good 👍
…tdown_with_new_server
{ | ||
connectionHandler_.stop(yield); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be covered by test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1801 +/- ##
===========================================
- Coverage 71.45% 71.42% -0.03%
===========================================
Files 321 325 +4
Lines 13227 13321 +94
Branches 6737 6789 +52
===========================================
+ Hits 9451 9515 +64
- Misses 1958 1966 +8
- Partials 1818 1840 +22 ☔ View full report in Codecov by Sentry. |
For #442. This is a WIP PR containing current state of graceful shutdown.