Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reading log_channels levels from config #1821

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

kuznetsss
Copy link
Collaborator

No description provided.

PeterChen13579
PeterChen13579 previously approved these changes Jan 10, 2025
Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few const I found. Feel free to ignore cuz clangtidy will add it, although not sure about the one in logger.cpp 👍

src/util/log/Logger.cpp Outdated Show resolved Hide resolved
tests/unit/LoggerTests.cpp Outdated Show resolved Hide resolved
tests/unit/LoggerTests.cpp Outdated Show resolved Hide resolved
cindyyan317
cindyyan317 previously approved these changes Jan 13, 2025
Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 unittests 💯
Left small nits. LGTM.

@kuznetsss kuznetsss dismissed stale reviews from PeterChen13579 and cindyyan317 via 7c4c2cc January 13, 2025 15:54
Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.72%. Comparing base (91c00e7) to head (7c4c2cc).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1821      +/-   ##
===========================================
+ Coverage    71.45%   71.72%   +0.27%     
===========================================
  Files          321      322       +1     
  Lines        13227    13235       +8     
  Branches      6737     6737              
===========================================
+ Hits          9451     9493      +42     
+ Misses        1958     1907      -51     
- Partials      1818     1835      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuznetsss kuznetsss merged commit 9659d98 into XRPLF:develop Jan 13, 2025
17 checks passed
@kuznetsss kuznetsss deleted the Fix_logger_config branch January 13, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants