-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reading log_channels levels from config #1821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few const I found. Feel free to ignore cuz clangtidy will add it, although not sure about the one in logger.cpp 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 unittests 💯
Left small nits. LGTM.
7c4c2cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1821 +/- ##
===========================================
+ Coverage 71.45% 71.72% +0.27%
===========================================
Files 321 322 +1
Lines 13227 13235 +8
Branches 6737 6737
===========================================
+ Hits 9451 9493 +42
+ Misses 1958 1907 -51
- Partials 1818 1835 +17 ☔ View full report in Codecov by Sentry. |
No description provided.