Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AmmWithdraw LPTokenIn field name #587

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fix AmmWithdraw LPTokenIn field name #587

merged 3 commits into from
Dec 18, 2024

Conversation

nkramer44
Copy link
Collaborator

AmmWithdraw.lpTokensIn had an incorrect JSON field name mapping, ie LPTokensIn vs the correct LPTokenIn, which caused that field to never get serialized to binary.

This PR simply changes the name of that field in the @JsonProperty, and adds BinarySerializationTests for all AMM transactions to ensure our field mappings are correct.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (5013020) to head (e3262db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #587   +/-   ##
=========================================
  Coverage     92.02%   92.02%           
  Complexity     1843     1843           
=========================================
  Files           382      382           
  Lines          5115     5115           
  Branches        435      435           
=========================================
  Hits           4707     4707           
  Misses          272      272           
  Partials        136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappenin sappenin merged commit 613339d into main Dec 18, 2024
21 checks passed
@sappenin sappenin deleted the nk/fix-amm-withdraw branch December 18, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants