-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitis 13804 : XRT-SMI re-architecture Patch 1 #8656
Conversation
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After initial discussion, this PR seems good to me for our first step of re-architecture once it is ironed out and passes pipeline.
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
@@ -9,6 +9,17 @@ | |||
#include "tools/common/SubCmd.h" | |||
#include "tools/common/XBHelpMenus.h" | |||
|
|||
struct SubCmdValidateOptions { | |||
std::string m_device; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove m_ in the next iteration of changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the first iteration! Let's get this in asap so we can start some bash testing
Signed-off-by: Akshay Tondak <[email protected]>
Problem solved by the commit
This PR is the first in a series of PRs to follow for https://jira.xilinx.com/browse/VITIS-13804 and xrt-smi re-architecture.
This PR does the following :
What's next ?
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
https://jira.xilinx.com/browse/VITIS-13804 partially
How problem was solved, alternative solutions (if any) and why they were rejected
The problem was solved by coming up with a Json Schema and conforming to that when writing the SUbCmdJsonObjects classes.
Risks (if any) associated the changes in the commit
xrt-smi validate should be tested further since this changes the existing behavior.
What has been tested and how, request additional testing if necessary
Tested xrt-smi validate on windows and Linux platforms.
Documentation impact (if any)
N/A