Cherry picking upstream commits to update to newer torch version #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set PyTorch and TorchVision version to nightly release 2024-10-15. Tracker issue for the failing tests added to xfail_set in this PR. Issue: llvm#3796 This commit disables the failing sparse tensor tests since they are not maintained on day-to-day basis and blocks the roll PyTorch update for now. Signed-Off By: Vivek Khandelwal <[email protected]>
Set PyTorch and TorchVision version to nightly release 2024-10-20.
This commit sets the PyTorch and TorchVision version to nightly release 2024-10-29. This commit also fixes the CI failure after this commit llvm@54d9e24 got merged. The issue was that the CI checks in the PR were run before the previous roll pytorch update but the PR was actually merged after the roll pytorch update. Hence, the failure was not caught before merging the PR. While exporting the fx_graph through fx_importer for `rrelu` and `rrelu_with_noise` op for train mode, it decomposes the `aten.rrelu_with_noise` op based on the PyTorch decomposition which is the default behavior. However, the decomposition contains an input mutation specifically here https://github.com/pytorch/pytorch/blob/9bbe4a67ad137032add6a3b0b74bda66f5ef83d2/torch/_decomp/decompositions.py#L325, resulting in the runtime failure. This issue would probably be fixed by pytorch/pytorch#138503. Until then, the failing tests are added to the xfail set. Also, after the roll pytorch update following tests started passing for fx_importer, and fx_importer_stablehlo config. - "ElementwiseRreluTrainModule_basic" - "ElementwiseRreluTrainStaticModule_basic" - "ElementwiseRreluWithNoiseTrainModule_basic" - "ElementwiseRreluWithNoiseTrainStaticModule_basic" This commit also updates the dtype check for the `aten.linear` op since the op now expects both the input tensors to have the same dtype. Signed-Off By: Vivek Khandelwal <[email protected]>
This commit sets the PyTorch and TorchVision version to nightly release 2024-11-07. This commit also updates the dtype check for the `aten.fake_quantize_per_tensor_affine` and `aten.fake_quantize_per_tensor_affine_cachemask` op since the op now supports bfloat16 input. Signed-Off By: Vivek Khandelwal <[email protected]>
This commit sets the PyTorch and TorchVision version to nightly release 2024-12-01. This commit also updates the test checks in `test/python/fx_importer/v2.3/auto_functionalized.py`. Failing tests are tracked through llvm#3796. --------- Signed-off-by: Vivek Khandelwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old nightly packages disappeared from the torch mirror. Updating torch to a version that is available.
I also added those packages to the releases (https://github.com/Xilinx/torch-mlir/releases/tag/snapshot-nightly-2025-01) to keep them downloadable.