Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use plugin in newer IDE versions. #26

Merged
merged 6 commits into from
May 3, 2024

Conversation

prisca-c
Copy link
Contributor

@prisca-c prisca-c commented May 1, 2024

Hi,

This is a pull request to solve ticket #25 which is about the issue from using the plugin in newer jetbrains IDE (2024.*).

I'm new to Java, it's certainly not perfect but it work for now for me so i thought it'll be good to share. I'm open to any help/informations/... about this pull request so we don't let this plugin die !

I updated many things to make it work :

  • Supported IntelliJ version
  • Intellij gradle plugin
  • Gradle
  • Updated many method which were deprecated after updating gradle.properties props :
    • StartupActivity.runActivity -> ProjectActivity.execute
    • ToolWindowFactory.isApplicable -> ToolWindowFactory.isApplicableAsync

@Xstoudi
Copy link
Owner

Xstoudi commented May 3, 2024

Hey, thanks a lot for the PR!
I'll quickly review the deprecation changes and ensure it builds on every concerned platforms.

@Xstoudi Xstoudi merged commit 94575e1 into Xstoudi:main May 3, 2024
1 check passed
@Xstoudi
Copy link
Owner

Xstoudi commented May 3, 2024

@allcontributors please add @prisca-c for code

Copy link
Contributor

@Xstoudi

I've put up a pull request to add @prisca-c! 🎉

@prisca-c prisca-c deleted the update-plugin-nheira branch May 3, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants