Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destination aware log level filtering #9

Merged
merged 9 commits into from
Jul 27, 2024
Merged

Add destination aware log level filtering #9

merged 9 commits into from
Jul 27, 2024

Conversation

KrystalDelusion
Copy link
Member

No description provided.

@KrystalDelusion KrystalDelusion force-pushed the krys/destination_level branch from 972aca2 to 9999871 Compare March 26, 2024 02:46
@KrystalDelusion KrystalDelusion marked this pull request as ready for review March 26, 2024 04:23
jix
jix requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@jix jix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a quick review pass over the PR and left inline comments. With dest vs destination resolved this LGTM . Haven't done any extra testing, but CI with the added tests should be sufficient.

src/yosys_mau/task_loop/context.py Outdated Show resolved Hide resolved
src/yosys_mau/task_loop/logging.py Outdated Show resolved Hide resolved
src/yosys_mau/task_loop/logging.py Show resolved Hide resolved
tests/task_loop/test_logging.py Outdated Show resolved Hide resolved
src/yosys_mau/task_loop/logging.py Outdated Show resolved Hide resolved
@KrystalDelusion
Copy link
Member Author

KrystalDelusion commented Apr 19, 2024 •
edited
Loading

Test gets stuck in an infinite loop (pending #17 update)
Added you as a collaborator, so hopefully this time you can force push a rebase to my fork if you need to @jix :)
(also I'm not sure why I don't have write access to this repo, but that is why I had to fork)

@KrystalDelusion KrystalDelusion requested a review from jix April 19, 2024 00:05
@KrystalDelusion
Implement destination aware log level filtering
46815c0 
- Add optional destination_label to start_logging function.
- Add dictionary to map destination label to minimum log level.
- The default log handler gets the destination level for the label provided in start_logging;
  falling back to the default value if no label was given, or if the given label has not been
  assigned a level.
@KrystalDelusion
Add tests for destination log level filtering
5afdda4
@KrystalDelusion
Paremetrize log destination tests
5b54dd8
@KrystalDelusion
logging: Testing nested logging
8502447
@KrystalDelusion
logging: Fix linting
4314d77
@KrystalDelusion
logging: Use log writing task context for dest_levels
799604e 
Update tests and docs to match.
@KrystalDelusion
logging: Minor doc fixes
18a1761
@KrystalDelusion
Replace dest_ with destination_
4bed760
@KrystalDelusion
Remove destination_levels test assigning to None
4368c24
@KrystalDelusion KrystalDelusion force-pushed the krys/destination_level branch from 751f2ea to 4368c24 Compare July 22, 2024 22:38
@KrystalDelusion
Copy link
Member Author

That should work now, I reverted the context dict fix on this branch instead of rebasing it out, so I had to drop that commit when rebasing onto main.

@jix jix merged commit 7653205 into YosysHQ:main Jul 27, 2024
2 checks passed
@jix jix deleted the krys/destination_level branch July 27, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jix jix jix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrystalDelusion @jix