Add tooltip and info text to allow fingerprints

Yubico · Jan 22, 2025 · f3e789e · f3e789e
1 parent 671d6d7
commit f3e789e
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 0 deletions.
diff --git a/lib/l10n/app_de.arb b/lib/l10n/app_de.arb
@@ -692,6 +692,7 @@
     "l_rfc4514_invalid": "Ungültiges RFC 4514Format",
     "rfc4514_examples": "Beispiele:\nCN=Beispielname\nCN=jsmith,DC=example,DC=net",
     "s_allow_fingerprint": "Fingerabdruck zulassen",
+    "s_pin_policy": null,
     "s_output_format": null,
     "s_expiration_date": null,
     "p_algorithm_desc": null,

diff --git a/lib/l10n/app_en.arb b/lib/l10n/app_en.arb
@@ -692,6 +692,7 @@
     "l_rfc4514_invalid": "Invalid RFC 4514 format",
     "rfc4514_examples": "Examples:\nCN=Example Name\nCN=jsmith,DC=example,DC=net",
     "s_allow_fingerprint": "Allow fingerprint",
+    "s_pin_policy": "PIN policy",
     "s_output_format": "Output format",
     "s_expiration_date": "Expiration date",
     "p_algorithm_desc": "Key algorithm to use.",

diff --git a/lib/l10n/app_fr.arb b/lib/l10n/app_fr.arb
@@ -692,6 +692,7 @@
     "l_rfc4514_invalid": "Format RFC 4514 non valide",
     "rfc4514_examples": "Exemples\u00a0:\nCN=exemple de nom\nCN=jsmith,DC=exemple,DC=net",
     "s_allow_fingerprint": "Autoriser les empreintes digitales",
+    "s_pin_policy": null,
     "s_output_format": null,
     "s_expiration_date": null,
     "p_algorithm_desc": null,

diff --git a/lib/l10n/app_ja.arb b/lib/l10n/app_ja.arb
@@ -692,6 +692,7 @@
     "l_rfc4514_invalid": "無効なRFC 4514形式",
     "rfc4514_examples": "例：\nCN=Example Name CN=jsmith,DC=example,\nDC=net",
     "s_allow_fingerprint": "指紋認証を許可する",
+    "s_pin_policy": null,
     "s_output_format": null,
     "s_expiration_date": null,
     "p_algorithm_desc": null,

diff --git a/lib/l10n/app_pl.arb b/lib/l10n/app_pl.arb
@@ -692,6 +692,7 @@
     "l_rfc4514_invalid": "Format RFC 4514 jest nieprawidłowy",
     "rfc4514_examples": "Przykłady:\nCN=Przykładowa Nazwa\nCN=jkowalski,DC=przyklad,DC=pl",
     "s_allow_fingerprint": "Zezwalaj na odcisk palca",
+    "s_pin_policy": null,
     "s_output_format": null,
     "s_expiration_date": null,
     "p_algorithm_desc": null,

diff --git a/lib/l10n/app_sk.arb b/lib/l10n/app_sk.arb
@@ -692,6 +692,7 @@
     "l_rfc4514_invalid": "Neplatný formát RFC 4514",
     "rfc4514_examples": "Príklady:\nCN=Vzorové Meno\nCN=jnovak,DC=priklad,DC=net",
     "s_allow_fingerprint": "Povoliť odtlačok prsta",
+    "s_pin_policy": null,
     "s_output_format": null,
     "s_expiration_date": null,
     "p_algorithm_desc": null,

diff --git a/lib/l10n/app_vi.arb b/lib/l10n/app_vi.arb
@@ -692,6 +692,7 @@
     "l_rfc4514_invalid": "Định dạng RFC 4514 không hợp lệ",
     "rfc4514_examples": "Ví dụ:\nCN=Tên Ví dụ\nCN=jsmith,DC=example,DC=net",
     "s_allow_fingerprint": "Cho phép vân tay",
+    "s_pin_policy": null,
     "s_output_format": null,
     "s_expiration_date": null,
     "p_algorithm_desc": null,

diff --git a/lib/piv/views/generate_key_dialog.dart b/lib/piv/views/generate_key_dialog.dart
@@ -252,6 +252,7 @@ class _GenerateKeyDialogState extends ConsumerState<GenerateKeyDialog> {
                           ),
                         if (widget.showMatch)
                           FilterChip(
+                            tooltip: l10n.s_pin_policy,
                             label: Text(l10n.s_allow_fingerprint),
                             selected: _allowMatch,
                             onSelected: _generating
@@ -293,6 +294,16 @@ class _GenerateKeyDialogState extends ConsumerState<GenerateKeyDialog> {
                                 ),
                                 TextSpan(text: '\n'),
                                 TextSpan(text: l10n.p_expiration_date_desc),
+                                if (widget.showMatch) ...[
+                                  TextSpan(text: '\n' * 2),
+                                  TextSpan(
+                                    text: l10n.s_pin_policy,
+                                    style: textTheme.bodySmall
+                                        ?.copyWith(fontWeight: FontWeight.w700),
+                                  ),
+                                  TextSpan(text: '\n'),
+                                  TextSpan(text: l10n.p_key_options_bio_desc)
+                                ]
                               ],
                             ),
                           ),

diff --git a/lib/piv/views/import_file_dialog.dart b/lib/piv/views/import_file_dialog.dart
@@ -330,6 +330,7 @@ class _ImportFileDialogState extends ConsumerState<ImportFileDialog> {
                   ),
                   Text(l10n.p_key_options_bio_desc),
                   FilterChip(
+                    tooltip: l10n.s_pin_policy,
                     label: Text(l10n.s_allow_fingerprint),
                     selected: _allowMatch,
                     onSelected: _importing