Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refreshing shares image for book #710

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add refreshing shares image for book #710

merged 2 commits into from
Jan 15, 2025
+1 −1

Conversation

natalieesk
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 664bcc8):

https://frost-book--pr710-refreshing-shares-im-fwf4sdwj.web.app

(expires Tue, 28 Jan 2025 18:26:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c

conradoplg
conradoplg requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind changing calculate_refresh_shares() in the figure to compute_refresh_shares()?

Also I think it would be helpful to include the old KeyPackage in the figure as an input to refresh_share()

@natalieesk natalieesk force-pushed the refreshing_shares_image branch from 9d2bddf to cf1d8fe Compare January 14, 2025 17:17
conradoplg
conradoplg approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

mergify bot added a commit that referenced this pull request Jan 15, 2025
@mergify
Merge of #710
c6a033b
@mergify mergify bot mentioned this pull request Jan 15, 2025
Closed
19 tasks
@mergify mergify bot merged commit 1a3578b into main Jan 15, 2025
22 checks passed
@mergify mergify bot deleted the refreshing_shares_image branch January 15, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

Assignees

@natalieesk natalieesk

Labels
None yet
Projects
FROST
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natalieesk @conradoplg