Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/high number fix #30

Merged
merged 5 commits into from
May 25, 2024
Merged

Hotfix/high number fix #30

merged 5 commits into from
May 25, 2024

Conversation

a7ex
Copy link
Owner

@a7ex a7ex commented May 22, 2024

No description provided.

@alexdeem
Copy link
Collaborator

Would using a UInt64 for execution counts be cleaner than parsing as a Double and converting back to Int?

@a7ex
Copy link
Owner Author

a7ex commented May 22, 2024

Would using a UInt64 for execution counts be cleaner than parsing as a Double and converting back to Int?

I didn't expect Codable to accept UInt64.

@a7ex
Copy link
Owner Author

a7ex commented May 22, 2024

Would using a UInt64 for execution counts be cleaner than parsing as a Double and converting back to Int?

Thanks for pointing that out. Apparently UInt64 is what Xcode is using for the executionCount.

@a7ex a7ex requested a review from Brett-Best May 23, 2024 06:59
Copy link
Collaborator

@Brett-Best Brett-Best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments inline and also below :)

It would be good if we could get the path URL to be relative like the code coverage output, this is needed for GitLab.

The check name could also be issueSummary.issueType rather than a hash.
Not that this appears to show in GitLab anyhow.

Thank you for doing this!

@a7ex a7ex merged commit 37da5c0 into main May 25, 2024
1 check passed
@a7ex a7ex deleted the hotfix/high-number-fix branch May 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants