Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eurovision Song Contest Analysis #460

Closed
wants to merge 1 commit into from

Conversation

mariam7084
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Eurovision Song Contest Analysis #396

  • Info about the related issue (Aim of the project) : To perform data analysis on the given dataset and drive meaningful conclusions.
  • Name: Mariam
  • GitHub ID: https://github.com/mariam7084
  • Idenitfy yourself: KWoC

Closes: #396

Describe the add-ons or changes you've made 📃

performed exploratory data analysis, visualized the data and derived conclusions from it.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x] Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made
I have re run the code on google colab and on my local machine to ensure it works fine and no error pops up

Checklist: ☑️

  • [ x] My code follows the guidelines of this project.
  • [ x] I have performed a self-review of my own code.
  • [x ] I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • [ x] My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @mariam7084 :)

@abhisheks008 abhisheks008 changed the title Add files via upload Eurovision Song Contest Analysis Dec 26, 2023
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mariam7084 this project is not upto the mark. Please create more EDA 'cause this a data analysis project and you need to find out the conclusions using this dataset.

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Dec 26, 2023
@mariam7084 mariam7084 closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requested Changes ⚙️ Some changes have been requested in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eurovision Song Contest Analysis
2 participants